Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blooms): Limit task retries in bloom planner #13139

Merged
merged 2 commits into from
Jun 5, 2024
Merged

refactor(blooms): Limit task retries in bloom planner #13139

merged 2 commits into from
Jun 5, 2024

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Jun 5, 2024 •
edited
Loading

What this PR does / why we need it:
In #13064 we introduced a retry mechanism for tasks. In this PR we limit how many times a given task can be retried.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 5, 2024
@salvacorts salvacorts marked this pull request as ready for review June 5, 2024 10:58
@salvacorts salvacorts requested a review from a team as a code owner June 5, 2024 10:58
@salvacorts salvacorts merged commit f788726 into main Jun 5, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/bloom-refactor/max-task-retries branch June 5, 2024 16:55
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@chaudum chaudum mentioned this pull request Aug 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvacorts @owen-d